ENG-1703 Allow to access a Web UI with a space's credentials#1005
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
maparent
force-pushed
the
eng-1703-allow-to-access-a-web-ui-with-a-spaces-credentials
branch
2 times, most recently
from
cc87e82 to
2b89982
Compare
maparent
force-pushed
the
eng-1703-allow-to-access-a-web-ui-with-a-spaces-credentials
branch
from
2b89982 to
87b7053
Compare
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
The biggest change requests are:
- moving the handling of the token fetch/login from a side effect to event handler
- gracefully handling token/login failure with error message, ability to retry
| </div> | ||
| <div className={"setting-item " + (isLoggedIn ? "" : "hidden")}> | ||
| <div className="setting-item-info"> | ||
| <div className="setting-item-name">Group management</div> |
There was a problem hiding this comment.
What if I'm not an admin? In the future we should name this something more generic "Sync management" or "Discourse Graph sync"
cc @jsmorabito
There was a problem hiding this comment.
Whoever you are, you can create a group, and that makes you admin of that specific group. So that's a group management operation you can always do.
maparent
force-pushed
the
eng-1703-allow-to-access-a-web-ui-with-a-spaces-credentials
branch
from
2ee75a6 to
ab6e7ea
Compare
…Ref to avoid the double load in dev
maparent
force-pushed
the
eng-1703-allow-to-access-a-web-ui-with-a-spaces-credentials
branch
from
48ce65c to
3236347
Compare
|
@mdroidian tagged you earlier and untagged you: there was a login issue I thought I saw, but I'm quite sure it was an artifact. So should be ready for review. |
|
Oh, unless you requested changes again? In which case not sure which ones you requested. |
maparent
deleted the
eng-1703-allow-to-access-a-web-ui-with-a-spaces-credentials
branch
2 participants
https://linear.app/discourse-graphs/issue/ENG-1703/allow-to-access-a-web-ui-with-a-spaces-credentials
https://www.loom.com/share/282145e9dcd0490981fbd8d45030b1a6